Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product features for servicey things #17920

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Product features for servicey things #17920

merged 2 commits into from
Sep 10, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Aug 28, 2018 •
edited
Loading

@bdunne bdunne requested review from gtanzillo and Ladas August 28, 2018 19:56
@bdunne bdunne mentioned this pull request Aug 28, 2018
Merged
gtanzillo
gtanzillo approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo self-assigned this Aug 28, 2018
Ladas
Ladas approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2018

This pull request is not mergeable. Please rebase and repush.

@bdunne bdunne force-pushed the product_features_for_servicey_things branch from 3a9daf1 to 822642f Compare September 6, 2018 15:21
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2018

Checked commits bdunne/manageiq@e7a33db~...822642f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@gtanzillo gtanzillo added this to the Sprint 94 Ending Sept 10, 2018 milestone Sep 10, 2018
@gtanzillo gtanzillo merged commit e7863d1 into ManageIQ:master Sep 10, 2018
@bdunne bdunne deleted the product_features_for_servicey_things branch September 10, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
api enhancement providers/topology providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @gtanzillo @Ladas