Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared persistor definitions plus adding ServiceInstance #17933

Merged

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Aug 31, 2018

Shared persistor definitions plus adding ServiceInstance. We need
thre definitions shared so we can use it both for AWS and k8s.

Depends on:

@Ladas
Copy link
Contributor Author

Ladas commented Aug 31, 2018

@miq-bot add_label enhancement
@miq-bot assign @agrare

@agrare agrare closed this Sep 11, 2018
@agrare agrare reopened this Sep 11, 2018
@agrare agrare closed this Sep 11, 2018
@agrare agrare reopened this Sep 11, 2018
Shared persistor definitions plus adding ServiceInstance. We need
thre definitions shared so we can use it both for AWS and k8s.
@Ladas Ladas force-pushed the shared_persistor_definitions_for_service_catalog branch from e1ee502 to e8b13a2 Compare September 12, 2018 07:58
@miq-bot
Copy link
Member

miq-bot commented Sep 12, 2018

Checked commit Ladas@e8b13a2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🏆

@@ -1,6 +1,6 @@
class ServiceOffering < ApplicationRecord
belongs_to :ext_management_system, :foreign_key => "ems_id", :inverse_of => :service_offerings
belongs_to :service_broker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops how did that slip in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was added by a group of evil hobgoblins :-)

@agrare agrare merged commit 047586e into ManageIQ:master Sep 12, 2018
@agrare agrare added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants