Add product feature for displaying custom button events #17939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
custom-button-events-list-features
branch
from
c9e3eac
to
06057fb
Compare
|
Checked commit skateman@06057fb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_reviewer @h-kataria |
skateman
changed the title
h-kataria
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature is required for an API PR to pass. It will allow to list custom button events for users, groups and tenants through the API. @lpichler promised me that he will sort out the missing part where this (hidden) feature will be restricted to admin and super admin roles.
@miq-bot add_label enhancement, gaprindashvili/no, rbac
@miq-bot add_reviewer @lpichler
https://bugzilla.redhat.com/show_bug.cgi?id=1511126