Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add physical chassis details builder #17941

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

tadeboro
Copy link
Contributor

@tadeboro tadeboro commented Sep 4, 2018

This code is needed to properly implement physical chassis inventory update.

@miq-bot assign @agrare
@Mig-Bot add_reviewer @Ladas

@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2018

Checked commit xlab-si@41018eb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit 47f6109 into ManageIQ:master Sep 7, 2018
@agrare agrare added this to the Sprint 94 Ending Sept 10, 2018 milestone Sep 7, 2018
@tadeboro tadeboro deleted the physical-chassis-details branch September 8, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants