Allow ems to terminate connection after use #17959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Sep 12, 2018
| connection = connect(options) | ||
| yield connection | ||
| ensure | ||
| disconnect(connection) if connection |
There was a problem hiding this comment.
@borod108 I want to standardize on an ensure disconnect in core, do you need the rescue around your disconnect method? https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/app/models/manageiq/providers/redhat/infra_manager/api_integration.rb#L113
Looks like that rescue might be better in the disconnect method itself.
This commit adds a simple disconnect hook that allows ext management systems (providers) to terminate connection after it is no longer needed. Use case for such functionality is provider that needs to delete user session after the operation since user sessions are long-lived and number of concurrent live sessions is limited.
tadeboro
force-pushed
the
provider-disconnect
branch
from
ff9b80a
to
2619b1e
Compare
|
Checked commit xlab-si@2619b1e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
ManageIQ/manageiq-providers-ovirt#286 was merged so merging this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple disconnect hook that allows ext management
systems (providers) to terminate connection after it is no longer
needed.
Use case for such functionality is provider that needs to delete user
session after the operation since user sessions are long-lived and
number of concurrent live sessions is limited.
@miq-bot assign @agrare