-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move virtual
definition for default_security_group
to OpenStack
#17979
Move virtual
definition for default_security_group
to OpenStack
#17979
Conversation
While RESPONSE: nope. this is not written to be able to use a delegate |
@kbrock So moving this class ManageIQ::Providers::Openstack::CloudManager::CloudTenant < ::CloudTenant
virtual_has_one :default_security_group, :uses => :security_groups
...
...
end |
a6f0509
to
6e6f2c8
Compare
Checked commit AparnaKarve@6e6f2c8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Moving the |
virtual_has_one
for default_security_group
for refresh to workvirtual
definition for default_security_group
to OpenStack
Please wait until ManageIQ/manageiq-providers-openstack#355 is green before merging this. (just to make sure we aren't merging this under false assumptions) |
@kbrock I wonder if it's the other way around... |
Verified locally that the OpenStack specs pass with this change and also with ManageIQ/manageiq-providers-openstack#355 |
Fixes the refresh issue.
Related PR #17975
/cc @agrare @Ladas