Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to handle the case when default value of internal is nil #17995

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

hsong-rh
Copy link
Contributor

Handle the missing case when internal attribute is nil.

Related PR:
#17781

@bzwei
Copy link
Contributor

bzwei commented Sep 18, 2018

Why the commit history is not clean? Where did commit 4e04f00 come from?

@miq-bot add_label bug
@miq-bot assign @gmcculloug

@hsong-rh
Copy link
Contributor Author

@bzwei It came from previous work. I'll remove it.

@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit hsong-rh@7de5642 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 19, 2018
@gmcculloug gmcculloug merged commit 9103bf2 into ManageIQ:master Sep 19, 2018
@hsong-rh hsong-rh deleted the fix_nil_internal branch September 19, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants