Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove todo with virtual attr inclusion in attr list #18019

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Sep 25, 2018

In service retirement, the line in bundled subtask creation that removed the virtual attributes from the new subtask attributes (#17912) is no longer necessary because #17996, which removes the attributes altogether, has been merged, yay.

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 25, 2018

@miq-bot assign @gmcculloug
@miq-bot add_reviewer @tinaafitz
@miq-bot add_label cleanup

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2018

Checked commit d-m-u@c195c67 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug merged commit dc7975f into ManageIQ:master Sep 26, 2018
@gmcculloug gmcculloug added this to the Sprint 96 Ending Oct 8, 2018 milestone Sep 26, 2018
@d-m-u d-m-u deleted the removing_hacky_virtual_attrs_todo branch September 26, 2018 12:39
@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 26, 2018

@miq-bot add_label hammer/yes

simaishi pushed a commit that referenced this pull request Sep 26, 2018
Remove todo with virtual attr inclusion in attr list

(cherry picked from commit dc7975f)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 1b5cf548d5ed513c4ce09a1cdcc618e5cb5a0f5e
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Sep 26 08:33:45 2018 -0400

    Merge pull request #18019 from d-m-u/removing_hacky_virtual_attrs_todo
    
    Remove todo with virtual attr inclusion in attr list
    
    (cherry picked from commit dc7975fc3047312f7c879428c24e098dd00ceddf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants