Fixed MiqExpression evaluation on tagged Services #18020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fixed-expression-with-tag-on-service
branch
3 times, most recently
from
60a6a73
to
d9b67e6
Compare
… instance of class descendent from Service passed: class descendent from Service has `service` method and string "service" passed to MiqExpression as reference, so MiqExpression trying to obtaine 'real' object using passed reference by invoking `service` method on instance of class descendent from Service, which is wrong. Passed object should not be subsrituted using reference if reference is "service" and object < ... < Service Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628727
…vice' and passed object is descendant from Service class
yrudman
force-pushed
the
fixed-expression-with-tag-on-service
branch
from
d9b67e6
to
321c844
Compare
|
Checked commits yrudman/manageiq@b74e3df~...321c844 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
yrudman
changed the title
|
@miq-bot add-label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Oct 1, 2018
…ervice Fixed MiqExpression evaluation on tagged Services (cherry picked from commit d670fe8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628727
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
…ervice Fixed MiqExpression evaluation on tagged Services (cherry picked from commit d670fe8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634809
|
Gaprindashvili backport details: |
nizaminabeel
pushed a commit
to nizaminabeel/manageiq
that referenced
this pull request
Dec 11, 2018
…tag-on-service Fixed MiqExpression evaluation on tagged Services (cherry picked from commit d670fe8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
MiqExpressionevaluating expression, it is trying to resolve referenced associations (if any).It is done by compare passed reference to a run-time object.
If passed object's class not the same as passed reference than
MiqExpressionconsider that passed reference is an association and trying to obtain associated object.ISSUE: If reference passed to
MiqExpressionis"service"and run-time object when evaluating expression is class descendant fromService,( likeServiceContainerTemplate) than MiqExpression will try to substitute passed object by invokingserviceon passed object, which will return nilFIX: Do not attempt to substitute original (runtime) object passed to MiqExpression if that object descendant from
Serviceand reference passed toMiqExpressionis"service"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628727
@miq-bot add-label bug, blocker, gaprindashvili/yes
\cc @gtanzillo