Fix Notifications None #18035
Merged
Fix Notifications None #18035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Sep 28, 2018
|
|
||
| describe "#enabled?" do | ||
| it "detects properly" do | ||
| expect(FactoryGirl.create(:notification_type, :audience => NotificationType::AUDIENCE_USER)).to be_enabled |
There was a problem hiding this comment.
Does these tests need to create?
How is enabled? related? Should it instead test instance.valid??
If not, should the enabled? tests test against all of the audiences?
There was a problem hiding this comment.
I guess I was testing the side effect of save.
not very straight forward
fixes ebd613a The notification type "NONE" was introduced, but it was not part of basic validations https://bugzilla.redhat.com/show_bug.cgi?id=1535177
kbrock
force-pushed
the
monitor_notifier_fix
branch
from
c1ba423
to
acd0a19
Compare
|
Checked commit kbrock@acd0a19 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Oct 1, 2018
Fix Notifications None (cherry picked from commit 8489078) https://bugzilla.redhat.com/show_bug.cgi?id=1535177
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification type
"NONE"(AUDIENCE_NONE) was introduced in #17673 , but it was not part of basic validationsThis was causing the RFE to fail:
https://bugzilla.redhat.com/show_bug.cgi?id=1535177