Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make provider's enable/disable methods protected #18037

Closed

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Oct 1, 2018

ExtManagementSystem.enable! and disable! should be used only by parent EMS to children or by pause!/resume, not as public methods

Issue: #17489

depends on:

@slemrmartin slemrmartin mentioned this pull request Oct 1, 2018
2 tasks
@slemrmartin slemrmartin changed the title Make provider's enable/disable methods protected [WIP] Make provider's enable/disable methods protected Oct 1, 2018
@miq-bot miq-bot added the wip label Oct 1, 2018
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commits slemrmartin/manageiq@ec3cb9e~...53dcf98 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 6 offenses detected

app/models/ext_management_system.rb

app/models/zone.rb

spec/models/miq_queue_spec.rb

@miq-bot
Copy link
Member

miq-bot commented Oct 22, 2018

This pull request is not mergeable. Please rebase and repush.

@slemrmartin slemrmartin deleted the ems-disable-protected branch January 24, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants