-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make provider's enable/disable methods protected #18037
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables/Disables ems with children and puts to maintenance zone https://bugzilla.redhat.com/show_bug.cgi?id=1455145
Name as constant
EMS cannot set invisible zone when enabled and change when disabled, MiqServer cannot set invisible zone
It only changes enabled flag.
maintenance zone identified by region and EMS.backup_zone renamed BZ https://bugzilla.redhat.com/show_bug.cgi?id=1455145
Spec and fix for nil zone BZ https://bugzilla.redhat.com/show_bug.cgi?id=1455145
slemrmartin
changed the title
Make provider's enable/disable methods protected
[WIP] Make provider's enable/disable methods protected
Oct 1, 2018
Checked commits slemrmartin/manageiq@ec3cb9e~...53dcf98 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/ext_management_system.rb
app/models/zone.rb
spec/models/miq_queue_spec.rb
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtManagementSystem.enable!
anddisable!
should be used only by parent EMS to children or bypause!
/resume
, not as public methodsIssue: #17489
depends on: