[WIP] Support mapped tags #18046
[WIP] Support mapped tags #18046
Conversation
lpichler
force-pushed
the
support_mapped_tags
branch
from
8709852
to
3ff0255
Compare
Method get_entry_details and MiqExpression#categories are used for listing mapped tag in expression editor in UI. https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/layouts/exp_atom/_edit_tags.html.haml#L27 We need to look for Classifiication object also in other regions and we need to find just if tag with proper name exist at least in any region.
lpichler
force-pushed
the
support_mapped_tags
branch
from
3ff0255
to
c9d9344
Compare
|
Checked commits lpichler/manageiq@512ecde~...c9d9344 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -46,6 +46,27 @@ class Classification < ApplicationRecord | |||
|
|
|||
| FIXTURE_FILE = FIXTURE_DIR.join("classifications.yml") | |||
|
|
|||
| def self.parent_classifications | |||
There was a problem hiding this comment.
The existing method categories does a similar thing but is scoped to the current region. Perhaps you can modify that method to get all the categories across all regions?
There was a problem hiding this comment.
the method categories lists (with these changes) categories with read_only=true && mapped categories from other regions. So it would not help in UI to display them in tag assignments.
|
This pull request is not mergeable. Please rebase and repush. |
| cats = where(:classifications => {:parent_id => 0}).includes(:tag, :children) | ||
| cats = cats.in_region(region_id) if region_id | ||
| cats.select { |c| c.ns == ns } | ||
| classificatin_scope = Classification.parent_classifications.references(:tag).includes(:tag, :children) |
There was a problem hiding this comment.
typo: s/classificatin/classification/g
| @@ -46,6 +46,27 @@ class Classification < ApplicationRecord | |||
|
|
|||
| FIXTURE_FILE = FIXTURE_DIR.join("classifications.yml") | |||
|
|
|||
| def self.parent_classifications | |||
| where(:classifications => {:parent_id => 0}) | |||
There was a problem hiding this comment.
This will change from 0 to nil in #18301. Consider abstracting this using is_category scope.
| condition_for_mapped_tags = ContainerLabelTagMapping::TAG_PREFIXES.map { "tags.name LIKE ?" }.join(' OR ') | ||
|
|
||
| tag_values = ContainerLabelTagMapping::TAG_PREFIXES.map { |x| "#{x}%:%" } | ||
| where(conditions).parent_classifications.includes(:tag).references(:tag).where(condition_for_mapped_tags, *tag_values).each do |c| |
There was a problem hiding this comment.
Could this use joins(:tag).merge(Tag.controlled_by_mapping) instead of directly querying on TAG_PREFIXES?
I'd like to not leak the fact it's currently implemented as prefix-based query
|
@cben thank you very much for review I appreciated it but it is not needed it, I will back to these PRs when we will needed it. closing |
This PR allows to use tags, categories(Classification + Tag model) to be usable in UI.
These PRs modify queries to display tags and categories(Classifications) with read_only=true flag and together with name with prefix of ContainerLabelTagMapping::TAG_PREFIXES (mapped labels) and from others regions. So this can be used on global region.
Briefly, user can use mapped tags from remote regions on global region.
Scenario
Let's assume you have mapped tags on remote region:
then after replication you can use them in for reporting, assigning and expresion editors:
report result with mapped tags:
it is also usable in advanced searches.
@miq-bot add_label enhancement
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1526000
#18015 (first part of 3)
PR is second part of 3
@miq-bot assign @gtanzillo