Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start memcached in any container runtime #18051

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Don't start memcached in any container runtime #18051

merged 1 commit into from
Oct 2, 2018

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Oct 2, 2018

This was originally fixed in 3d3f716 but was then broken again in 0735aec

This will allow the monolithic container image to run properly
cc @simaishi

@carbonin
Don't start memcached in any container runtime
a101c94 
This was originally fixed in 3d3f716 but was then broken again in 0735aec

This will allow the monolithic container image to run properly
@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2018

Checked commit carbonin@a101c94 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@bdunne bdunne merged commit 08f42d9 into ManageIQ:master Oct 2, 2018
@bdunne bdunne added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@bdunne @simaishi
Merge pull request #18051 from carbonin/dont_start_memcached_in_conta…
fcc62df 
…iners_again

Don't start memcached in any container runtime

(cherry picked from commit 08f42d9)
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit fcc62dfe8ae9959d3b541735b56649a2db1699b6
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Tue Oct 2 15:09:16 2018 -0400

    Merge pull request #18051 from carbonin/dont_start_memcached_in_containers_again
    
    Don't start memcached in any container runtime
    
    (cherry picked from commit 08f42d903fc6480acece38d6dc435567b222f8ce)

@carbonin carbonin deleted the dont_start_memcached_in_containers_again branch August 16, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdunne bdunne

Labels
bug core hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carbonin @miq-bot @simaishi @bdunne