Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't translate FileDepot types #18069

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Don't translate FileDepot types #18069

merged 1 commit into from
Oct 8, 2018

Conversation

mzazrivec
Copy link
Contributor

The types (NFS, AWS, ...) as they come from the backend should remain untranslated. Gettext should be applied in UI (if needed).

@miq-bot add_label internationalization, hammer/yes

@mzazrivec
Don't translate FileDepot types
d482735 
The types (NFS, AWS, ...) as they come from the backend should remain
untranslated. Gettext should be applied in UI (if needed).
@bdunne bdunne merged commit d1ccb82 into ManageIQ:master Oct 8, 2018
@bdunne bdunne self-assigned this Oct 8, 2018
@bdunne bdunne added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 8, 2018
simaishi pushed a commit that referenced this pull request Oct 8, 2018
@bdunne @simaishi
Merge pull request #18069 from mzazrivec/don_translate_file_depot_types
e84c8d8 
Don't translate FileDepot types

(cherry picked from commit d1ccb82)
@simaishi
Copy link
Contributor

simaishi commented Oct 8, 2018

Hammer backport details:

$ git log -1
commit e84c8d82df51fb82a634643daf7c85fbbfe99798
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Mon Oct 8 14:50:55 2018 -0400

    Merge pull request #18069 from mzazrivec/don_translate_file_depot_types
    
    Don't translate FileDepot types
    
    (cherry picked from commit d1ccb82d10b6311bb69dcf132aa7fd3bf4c3a11d)

@mzazrivec mzazrivec deleted the don_translate_file_depot_types branch October 9, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees

@bdunne bdunne

Labels
hammer/backported internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzazrivec @simaishi @bdunne @miq-bot