Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 5.1/5.0 compatibility: Use constant since string/symbol was removed #18077

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Rails 5.1/5.0 compatibility: Use constant since string/symbol was removed #18077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ class Application < Rails::Application

config.autoload_once_paths << Rails.root.join("lib", "vmdb", "console_methods.rb").to_s

config.middleware.use 'RequestStartedOnMiddleware'
require_relative '../lib/request_started_on_middleware'
config.middleware.use RequestStartedOnMiddleware
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also consider putting this change in the initializer as well, ala something like:

rails/rails@83b767ce#commitcomment-19818100

I have no preference if you do, it would just avoid a require when it will probably get autoloaded as part of app initialization anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference. I've always thought middlewares are important enough to be in the application.rb provided there aren't many of them. I guess we can put it in an initializer but thought this was ok as is since we can't rely upon autoload or reloading here.


# config.eager_load_paths accepts an array of paths from which Rails will eager load on boot if cache classes is enabled.
# Defaults to every folder in the app directory of the application.
Expand Down