Rails 5.0/5.1 prepare_binds_for_database is gone #18078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid relying on the connection to type cast the binds, this method was removed. It was replaced with the underlying implementation of the method, which is also used here to replace our usage. rails/rails@5465508 Extracted from ManageIQ#18076
jrafanie
force-pushed
the
rails_5_1_prepare_binds_for_database_was_removed
branch
from
9bf9dc2
to
651d6a0
Compare
NickLaMuro
reviewed
Oct 10, 2018
There was a problem hiding this comment.
This looks good to me. The change matches what is being done in the Rails commit, so seems good to me.
On a side note: I noticed they were doing an unnecessary "double map" in a few places now as a result of the change (in Rails core that is), so I might commit a patch for that (assuming it is still there)!
😉
Anyway, nice work! 👍
|
Checked commit jrafanie@651d6a0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
deleted the
rails_5_1_prepare_binds_for_database_was_removed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid relying on the connection to type cast the binds, this method was
removed. It was replaced with the underlying implementation of the
method, which is also used here to replace our usage.
rails/rails@5465508
Extracted from #18076