Add ext_management_system method to conversion host #18097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
agrare
reviewed
Oct 15, 2018
app/models/conversion_host.rb
Outdated
| @@ -7,6 +7,10 @@ class ConversionHost < ApplicationRecord | |||
| has_many :service_template_transformation_plan_tasks, :dependent => :nullify | |||
| has_many :active_tasks, -> { where(:state => 'active') }, :class_name => ServiceTemplateTransformationPlanTask, :inverse_of => :conversion_host | |||
|
|
|||
| def ext_management_system | |||
| resource.ext_management_system | |||
There was a problem hiding this comment.
You'd be better off using delegate :ext_management_system, :to => :resource
|
Ha I beat miq-bot by 1.5min! |
agrare
reviewed
Oct 15, 2018
app/models/conversion_host.rb
Outdated
| @@ -6,6 +6,7 @@ class ConversionHost < ApplicationRecord | |||
| belongs_to :resource, :polymorphic => true | |||
| has_many :service_template_transformation_plan_tasks, :dependent => :nullify | |||
| has_many :active_tasks, -> { where(:state => 'active') }, :class_name => ServiceTemplateTransformationPlanTask, :inverse_of => :conversion_host | |||
| delegate :ext_management_system, :to => :resource | |||
There was a problem hiding this comment.
You might also want :allow_nil => true so that if the conversion host isn't linked to any inventory item this doesn't raise a NoMethodError but just returns nil
|
Checked commits fabiendupont/manageiq@7646495~...90da9fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 15, 2018
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Oct 16, 2018
Add ext_management_system method to conversion host (cherry picked from commit 8bc0049) https://bugzilla.redhat.com/show_bug.cgi?id=1634029
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the conversion host, it might be useful to filter by EMS. For example, when throttling the migrations, one of the metrics is the number of concurrent tasks per EMS. So, getting the conversion hosts per EMS will be useful. This PR adds the
ext_management_systemmethod that returns the EMS of the resource. Currently, throttling is done in Automate and this PR requires it: ManageIQ/manageiq-content#441Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1634029