Add resource ems_ref and ip addresses to virt-v2v options hash #18101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
force-pushed
the
conversion_host_ems_ref
branch
from
36a8531
to
dbb9fc9
Compare
ghost
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
ghost
force-pushed
the
conversion_host_ems_ref
branch
from
dbb9fc9
to
e338897
Compare
agrare
reviewed
Oct 18, 2018
app/models/conversion_host.rb
Outdated
| @@ -8,6 +8,7 @@ class ConversionHost < ApplicationRecord | |||
| has_many :active_tasks, -> { where(:state => 'active') }, :class_name => ServiceTemplateTransformationPlanTask, :inverse_of => :conversion_host | |||
| delegate :ext_management_system, :to => :resource, :allow_nil => true | |||
| delegate :hostname, :to => :resource, :allow_nil => true | |||
| delegate :ems_ref, :to => :resource, :allow_nil => true | |||
There was a problem hiding this comment.
You can put these on the same line e.g. delegate :hostname, :ems_ref, :to => .....
|
Checked commits fabiendupont/manageiq@262935b~...4340b78 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 18, 2018
simaishi
pushed a commit
that referenced
this pull request
Oct 18, 2018
Add resource ems_ref and ip addresses to virt-v2v options hash (cherry picked from commit 88f7d2f) https://bugzilla.redhat.com/show_bug.cgi?id=1634029
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build the virt-v2v options hash for OpenStack, the ServiceTemplateTransformationPlanTask needs the
ems_refof the conversion host to expose it asosp_server_idin the options hash. This PR exposes the resourceems_refin ConversionHost and enrich the options hash.This PR also adds the IP address to the network mappings in options hash, as it is required to generate the network ports that will be attached to the instance.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1634029