Use Settings.active_task_timeout for db backup task instead of hardcoded value #18124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs instead of hardcoded 3600 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638432
yrudman
force-pushed
the
customizable-timeout-when-db-backup
branch
from
a094a3c
to
012f361
Compare
yrudman
force-pushed
the
customizable-timeout-when-db-backup
branch
from
012f361
to
939f7fd
Compare
|
Checked commits yrudman/manageiq@cae0b1c~...939f7fd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@jrafanie could you review |
gtanzillo
approved these changes
Oct 31, 2018
|
Wow, thanks, I lost track of this one... sorry. Looks good. |
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2018
…ackup Use Settings.active_task_timeout for db backup task instead of hardcoded value (cherry picked from commit 079996b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638432
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: timeout for task to backup db is hardcoded to 1 hour, which is not enough for big databases
Fix: use existing
Settings.active_task_timeoutFixes https://bugzilla.redhat.com/show_bug.cgi?id=1638432
@miq-bot add-label bug, hammer/yes, core