Fix OpenStack virt-v2v-wrapper options hash #18143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits fabiendupont/manageiq@d8a6c63~...45e8156 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add-reviewer jameswnl |
jameswnl
reviewed
Nov 1, 2018
| @@ -517,7 +517,7 @@ | |||
| let(:dst_cloud_network_2) { FactoryGirl.create(:cloud_network) } | |||
| let(:dst_flavor) { FactoryGirl.create(:flavor) } | |||
| let(:dst_security_group) { FactoryGirl.create(:security_group) } | |||
| let(:conversion_host_vm) { FactoryGirl.create(:vm, :ext_management_system => dst_ems) } | |||
| let(:conversion_host_vm) { FactoryGirl.create(:vm_openstack, :ext_management_system => dst_ems, :cloud_tenant => dst_cloud_tenant) } | |||
There was a problem hiding this comment.
Can we assign a name to this :cloud_tenant and have an expect statement to match it against the os_project_name? My thought is that: If this had been there, we would have detected this bug early on.
|
This pull request is not mergeable. Please rebase and repush. |
ghost
force-pushed
the
v2v_fix_openstack_migration
branch
from
45e8156
to
84805c9
Compare
jameswnl
approved these changes
Nov 7, 2018
agrare
approved these changes
Nov 7, 2018
|
Looks like CI status isn't syncing, https://travis-ci.org/ManageIQ/manageiq/builds/451965303?utm_source=github_status&utm_medium=notification says this is green. |
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2018
…tion Fix OpenStack virt-v2v-wrapper options hash (cherry picked from commit 69f83f0) https://bugzilla.redhat.com/show_bug.cgi?id=1644069
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating the to OpenStack, the hash passed to virt-v2v-wrapper contains the OpenStack authentication URL and the authentication project name. There was an error and this PR fixes it.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1644069