Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flavor and security group collection #18147

Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2018

The current code looks for flavor and security group in the miq_request, while it is stored in the VM resource of the request. This breaks migration to OpenStack. This PR fixes it.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1644601

@ghost
Copy link
Author

ghost commented Oct 31, 2018

@miq-bot add-label transformation, bug, hammer/yes, blocker

@ghost
Copy link
Author

ghost commented Oct 31, 2018

@jameswnl @agrare could you please review ?

@agrare agrare self-assigned this Oct 31, 2018
@agrare agrare merged commit 478c596 into ManageIQ:master Oct 31, 2018
@agrare agrare added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 31, 2018
simaishi pushed a commit that referenced this pull request Nov 1, 2018
…r_openstack

Fix flavor and security group collection

(cherry picked from commit 478c596)

https://bugzilla.redhat.com/show_bug.cgi?id=1644601
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2018

Hammer backport details:

$ git log -1
commit 43de74ef59e53129e5accc35f54f512260cf29d3
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Oct 31 13:56:54 2018 -0400

    Merge pull request #18147 from fdupont-redhat/v2v_fix_options_hash_for_openstack
    
    Fix flavor and security group collection
    
    (cherry picked from commit 478c596397427001a9c83f5d5394c684b17adbe4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1644601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants