Update ancestry to latest 3.0.x #18164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit kbrock@d2641c9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
reviewed
Nov 6, 2018
lib/patches/ancestry_patch.rb
Outdated
|
|
||
| # TODO: delete |
There was a problem hiding this comment.
Should this be deprecated instead?
bdunne
reviewed
Nov 6, 2018
lib/patches/ancestry_patch.rb
Outdated
| @@ -62,7 +63,8 @@ def depth | |||
|
|
|||
| STRING_BASED_KEYS = %i[string uuid text].freeze | |||
| def cast_primary_key(key) | |||
| if STRING_BASED_KEYS.include?(primary_key_type) | |||
| # self.class.primary_key_is_an_integer? ? key.to_i : key | |||
|
@bdunne thanks for keeping me honest |
This was referenced Nov 6, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point ancestry to the latest version
This fixes an issue in our patch that prevented us from upgrading to the latest version of ancestry.
A number of rails 5.1 and 5.2 bugs have been (and are being) fixed.
This isolates us from running into problems that have already been fixed.
This version of ancestry is backwards compatible to rails 4.x
I deleted
parse_ancestry_columnas the stock version uses less memory and a tad faster.ips
obj.ancestor_idsroot.ancestor_idsmemsize
obj.ancestor_idsroot.ancestor_idsobjects
obj.ancestor_idsroot.ancestor_ids