Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --port to evm:dba rake tasks #18186

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Add --port to evm:dba rake tasks #18186

merged 1 commit into from
Nov 12, 2018

Conversation

NickLaMuro
Copy link
Member

@NickLaMuro NickLaMuro commented Nov 10, 2018 •
edited
Loading

Minor thing that I currently am using to allow me to test backup restores for rake tasks against a secondary DB on the same host. Possibly something we should consider adding to appliance_console but for now it isn't necessary.

@NickLaMuro
Copy link
Member Author

@miq-bot assign @carbonin

This is super minor, and I can patch it in when I need it, so feel free to review this at your leisure.

@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2018

Checked commit NickLaMuro@3e88750 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

lib/tasks/evm_dba.rake

@carbonin carbonin merged commit 7bbe250 into ManageIQ:master Nov 12, 2018
@carbonin carbonin added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 12, 2018
simaishi pushed a commit that referenced this pull request Nov 12, 2018
@carbonin @simaishi
Merge pull request #18186 from NickLaMuro/add-port-option-to-evm-dba-…
26b0236 
…tasks

Add --port to evm:dba rake tasks

(cherry picked from commit 7bbe250)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 26b0236eb532ee99d217673eee9c910f6002e7e1
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Mon Nov 12 14:25:23 2018 -0500

    Merge pull request #18186 from NickLaMuro/add-port-option-to-evm-dba-tasks
    
    Add --port to evm:dba rake tasks
    
    (cherry picked from commit 7bbe250535faed5337bc3c5805ca27ea42523c84)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carbonin carbonin

Labels
enhancement hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickLaMuro @miq-bot @simaishi @carbonin