Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conversion Host features #18190

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Add Conversion Host features #18190

merged 3 commits into from
Nov 15, 2018

Conversation

djberg96
Copy link
Contributor

Adds features for ConversionHosts in order to satisfy ManageIQ/manageiq-api#507 as part of the v2v effort.

Marked as a WIP for now until my fellow v2v compatriots can confirm this is correct.

@djberg96 djberg96 changed the title [WIP] Add Conversion Host features Add Conversion Host features Nov 14, 2018
@djberg96
Copy link
Contributor Author

@martinpovolny I've nested it under Migrations, and I can see in the database that it's set the product feature parent as expected.

@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2018

Checked commits https://github.com/djberg96/manageiq/compare/cdcdd7ec4f9f28e94da21f8053f8ca74512a7707~...182ca5c6bdbd7c09cc00ee64ebe5c5108f4c5f6f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@miq-bot miq-bot removed the wip label Nov 14, 2018
@martinpovolny martinpovolny self-assigned this Nov 15, 2018
@martinpovolny martinpovolny merged commit 808a114 into ManageIQ:master Nov 15, 2018
@martinpovolny martinpovolny added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 15, 2018
@martinpovolny
Copy link
Member

I am going to rebase #18203 on top of this one. And that will be the point where the content of the RBAC tree under roles will be expected to be correct.

simaishi pushed a commit that referenced this pull request Nov 15, 2018
Add Conversion Host features

(cherry picked from commit 808a114)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit ea2cfab07d0453dc8553b97daf81dae3486c452a
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Nov 15 17:12:10 2018 +0100

    Merge pull request #18190 from djberg96/add_conversion_host_roles
    
    Add Conversion Host features
    
    (cherry picked from commit 808a114c18fba6ffe35a816a4ec67fa7cf0c7d68)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants