Save mappings to options hash when calculated #18194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
agrare
reviewed
Nov 13, 2018
| :weight => disk.size.to_f / source.allocated_disk_storage.to_f * 100 | ||
| } | ||
| options[:virtv2v_disks] ||= calculate_virtv2v_disks.tap do |disks| | ||
| update_attributes(:options => options.merge(:virtv2v_disks => disks)) | ||
| end |
There was a problem hiding this comment.
How about just
return options[:virtv2v_disks] if options[:virtv2v_disks].present?
options[:virtv2v_disks] = calculate_virtv2v_disks
save!
options[:virtv2v_disks]
|
Checked commits fabiendupont/manageiq@b823e91~...2698585 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@jameswnl PTAL |
|
Looks ok to me. Just not sure if breaking into 2 new methods is doing any good |
jameswnl
suggested changes
Nov 13, 2018
| end | ||
| return options[:virtv2v_disks] if options[:virtv2v_disks].present? | ||
|
|
||
| options[:virtv2v_disks] = calculate_virtv2v_disks |
There was a problem hiding this comment.
you would need to do self.options[...
There was a problem hiding this comment.
actually no need. the reference is unambiguous enough to hitting the record's attribute
agrare
approved these changes
Nov 13, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2018
…rst_call Save mappings to options hash when calculated (cherry picked from commit 3b7f61a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649020
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the network mappings and virtv2v disks, we add them to the task options hash for future consumption, such as when building the virt-v2v-wrapper options. This PR effectively save the options hash, when previous code only changed the in-memory value.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1649020