Move the backend-generated PDF report's styling from the frontend #18226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinpovolny I realize the fact that having the PDF generation separated between the two repos is wrong and I'm thinking on a better solution... |
|
Please see ManageIQ/manageiq-ui-classic#4949 (comment) I'm not sure we need to be abusing the asset pipeline for this. EDIT: LGTM now 👍 |
skateman
force-pushed
the
pdf-report-stylesheet-path
branch
from
facd72c
to
1d4acf5
Compare
skateman
changed the title
skateman
force-pushed
the
pdf-report-stylesheet-path
branch
from
1d4acf5
to
7e6b905
Compare
simaishi
pushed a commit
that referenced
this pull request
Nov 26, 2018
Move the backend-generated PDF report's styling from the frontend (cherry picked from commit 3129ad7) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650057
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no on-the-fly asset compilation in production, there is no access to the
Rails.application.assetsobject. Also thepdf_report.cssand the files it loads are no longer used in the UI. Eventually this styling needs to be removed and a unified PDF generation should be used, probably via a headless webdriver on the backend.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650057
@miq-bot add_label bug, gaprindashvili/no, hammer/yes
@miq-bot add_reviewer @h-kataria
@miq-bot add_reviewer @martinpovolny