Add job_timeout parameter for upgrade_cluster

[borod108]

The motivation here is that we need the job to have one timeout, and the
Ansible role to have another - the job will end if the timeout from the
time it was created will pass, while Ansible playbook will only timeout if it is
stack for too long on one phase. So we will want to set the job timeout
to something huge - 1 year, and set a real timeout through the playbook
extra_vars.

This is part of implementing: https://bugzilla.redhat.com/show_bug.cgi?id=1644605

[borod108]

@agrare I think this is the last one for this phase of the cluster upgrade.

[miq-bot]

Checked commit borod108@e1965d6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[agrare]

@borod108 is there a corresponding PR to manageiq-providers-ovirt to accept and set job_timeout in ManageIQ::Providers::Redhat::AnsibleRoleWorkflow ?

[borod108]

@agrare I do not think that is required. https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/app/models/manageiq/providers/redhat/ansible_role_workflow.rb
we do not override anything that uses job_timeout.
We just pass the timeout_job as time to the create_job:

manageiq/app/models/manageiq/providers/ansible_role_workflow.rb

Line 2 in c4757b9

def self.job_options(env_vars, extra_vars, role_options, timeout, poll_interval)

[agrare]

@borod108 but doesn't that not impact the job timeout since it is a class method?

Forgot that you already did that here https://github.com/ManageIQ/manageiq/pull/18108/files#diff-a8d27c2744e902e4796e24bb1560aec7R6 👍

[agrare]

@borod108 if this is the last part needed for backporting this feature lets get on the migration for STI for the other infra providers so we can get this moved to ovirt.

[borod108]

@miq-bot add-label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit aa3b07422c46d5e11a7ee4b7236230b4b2dfbbea
Author: Adam Grare <agrare@redhat.com>
Date:   Thu Nov 29 08:50:41 2018 -0500

    Merge pull request #18230 from borod108/rfe/upgrade_cluster_role_options
    
    Add job_timeout parameter for upgrade_cluster
    
    (cherry picked from commit 0e1006bce4c40edaa7059247886ad08524f97b8c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1644605