Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenancy for central admin #18263

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Dec 4, 2018

This PR is adding a way how to use tenancy from remote region in central admin.

This change would require the user to manually create the tenant structure that exists in the remote regions in the global region.

Links

@miq-bot assign @gtanzillo
@miq-bot add_label enhancement, rbac

end

def self.regional_tenants(tenant)
where(arel_table.grouping(arel_attribute(:name).eq(tenant.name)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a case insensitive match so that it's consistent with users and and groups

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

@lpichler lpichler changed the title [WIP] Tenancy for central admin Tenancy for central admin Dec 11, 2018
@miq-bot miq-bot removed the wip label Dec 11, 2018
accessible_tenant_ids are tenant ids determined
for selection of resources by certain tenant strategy.

This update extend tenant ids about tenant ids from
other regions. This tenant ids are determined by
finding tenant with same name as we have in other
regions and tenant is used to get tenant ids
by certaion tenant strategy.
@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2018

Checked commit lpichler@81f2d38 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @lpichler 👍 Let's discuss/merge when we chat later.

@gtanzillo gtanzillo added this to the Sprint 102 Ending Jan 7, 2019 milestone Dec 18, 2018
@gtanzillo gtanzillo merged commit cb94114 into ManageIQ:master Dec 18, 2018
@lpichler lpichler deleted the tenancy_for_central_admin branch December 18, 2018 16:17
@simaishi
Copy link
Contributor

@lpichler Can this be hammer/yes?

@lpichler
Copy link
Contributor Author

lpichler commented Apr 2, 2019

@lpichler Can this be hammer/yes?

@simaishi yes, I tested it locally.

simaishi pushed a commit that referenced this pull request Apr 3, 2019
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2019

Hammer backport details:

$ git log -1
commit 365efb778ce1b8ef06d6ccad1367860a7aa909ff
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue Dec 18 11:16:43 2018 -0500

    Merge pull request #18263 from lpichler/tenancy_for_central_admin
    
    Tenancy for central admin
    
    (cherry picked from commit cb94114d06223d8315c596432f598974e376cada)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1695631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants