Suppress output to stdout and stderr in copy_report_structure_spec.rb

[yrudman]

Suppress output to stdout and stderr in copy_report_structure_spec.rb

Follow-up to #18066
Thank you @djberg96 for pointing out

BEFORE:

AFTER:

@miq-bot add-label test, gaprindashvili/yes, hammer/yes

\cc @gtanzillo

[djberg96]

I think we need to ensure that it's reset afterwards, otherwise it affects other specs (I think). So, perhaps something like this:

before do
  old_stdout, old_stderr = $stdout, $stderr
  $stdout = $stderr = StringIO.new
end

after do
  $stdout, $stderr = old_stdout, old_stderr
end

[kbrock]

@yrudman also, we do have a mechanism for testing/capturing this

expect { some code }.to output('this was printed out').to_stdout

there are a few examples in our code base

[yrudman]

@djberg96 yes, need to restore original values

@kbrock it is good to know!

[miq-bot]

Checked commit yrudman@ab4e559 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[djberg96]

👍

[kbrock]

@yrudman If the output from this code is needed on stdout, then it seems the tests should check what is being printed out rather than just eating it.

Is it possible to add the stdout to the tests?
That way, if there is another error or something here, we catch it - rather than just eat that too

expect($stdout).to receive(:puts).with(/Copying failed/)