Raise a notification for each repo that fails to enable #18290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Checked commit carbonin@c25631a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
reviewed
Dec 12, 2018
| @@ -136,6 +136,7 @@ def enable_repos | |||
| LinuxAdmin::SubscriptionManager.enable_repo(repo, assemble_registration_options) | |||
| rescue AwesomeSpawn::CommandResultError | |||
| update_attributes(:upgrade_message => "failed to enable #{repo}") | |||
| Notification.create(:type => "enable_update_repo_failed", :options => {:repo_name => repo}) | |||
There was a problem hiding this comment.
Looks good. I don't know if we can bubble up more information out of the exception but that might be too much information. Either way, that's more than what you need here.
jrafanie
reviewed
Dec 12, 2018
| @@ -285,6 +285,11 @@ | |||
| :expires_in: 24.hours | |||
| :level: :error | |||
| :audience: superadmin | |||
| - :name: enable_update_repo_failed | |||
| :message: 'Subscription Manager failed to enable repo %{repo_name}' | |||
There was a problem hiding this comment.
I like how we're consistently inconsistent with putting periods at the end of the message. 🤣
jrafanie
reviewed
Dec 12, 2018
|
|
||
| it "raises a notification for repos which fail to enable" do | ||
| NotificationType.seed | ||
| result = AwesomeSpawn::CommandResult.new("stuff", "things", "more things", 1) |
jrafanie
approved these changes
Dec 12, 2018
simaishi
pushed a commit
that referenced
this pull request
Dec 13, 2018
Raise a notification for each repo that fails to enable (cherry picked from commit 1eb52ea) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518801
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518801