Re-raise the LoadError if it is not for the file we are trying to load #18343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this could mask LoadErrors when the file we are trying to load is found and loaded, but it requires another file which is not found, raises LoadError and incorrectly runs the code in the rescue block.
|
I tried to get the tests working, but can not accurately reproduce the problem in rspec. |
|
Checked commit bdunne@87cb1fd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Jan 9, 2019
jrafanie
approved these changes
Jan 9, 2019
It's too bad the tests couldn't recreate it exactly. I'm surprised how far you got with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this could mask LoadErrors when the file we are trying to load is found and loaded, but it requires another file which is not found, raises LoadError and incorrectly runs the code in the rescue block.