V2V - Collect virt-v2v PID from conversion host in kill_virtv2v

[ghost]

In the current implementation, we still use the old format of task.options[:virtv2v_wrapper] to identify the PID of virt-v2v. The value is always nil as we don't store it there anymore, which in turns makes the cancellation ineffective. This PR fixes it by calling get_conversion_state, that gets the state from the conversion host, and thus the PID.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1666799

[ghost]

@miq-bot add-label transformation, bug, hammer/yes, blocker

[jameswnl]

@fdupont-redhat why don't we store that anymore, since get_conversion_state is retrieving it already?

[ghost]

Because we get the whole state in VMCheckTransformed method. So, that's just an extra retrieval when we need to cleanup the conversion stuff.

[miq-bot]

Checked commits fabiendupont/manageiq@8e5e70f~...38a7994 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

@fdupont-redhat does the PID change over the course of a service_template_transformation_plan_task ? That seems like something we should be caching instead of doing another ssh call to get the state file.

[agrare]

Since this is a blocker I'll merge but @fdupont-redhat lets look at this refactoring in a follow-up, I'd rather not have to do an extra ssh call before the cancel

[ghost]

@agree I do agree that it could be cached, as the PID doesn't change once virt-v2v is started. It's a broader discussion about what should be stored in options has. Anyway, thanks for the merge.

[simaishi]

Hammer backport details:

$ git log -1
commit 0e878b781b1cfdf4b3cd5c35fbfb29578ad30679
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Jan 18 14:37:51 2019 -0500

    Merge pull request #18372 from fdupont-redhat/v2v_fix_virtv2v_kill
    
    V2V - Collect virt-v2v PID from conversion host in kill_virtv2v
    
    (cherry picked from commit 526045d22faae29ad8d74e4625c9f09206d5f97e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1672699