[GAPRINDASHVILI] Add mark_retired method to not reset retirement_requester #18376
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
d-m-u
force-pushed
the
stop_reset_of_retirement_requester
branch
2 times, most recently
from
97d7c1f
to
cf47ff8
Compare
d-m-u
force-pushed
the
stop_reset_of_retirement_requester
branch
4 times, most recently
from
99b576d
to
a54a2b2
Compare
d-m-u
force-pushed
the
stop_reset_of_retirement_requester
branch
from
a54a2b2
to
a384e28
Compare
|
Checked commit d-m-u@a384e28 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we have a column name and a method name that are equivalent, finish_retirement used to reset the retirement_requester to nil. Changing the method to call a different method that only sets the field name prevents this from being reset to nil at the end.
Backport of #18325
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641812
@miq-bot add_label bug, blocker
@miq-bot assign @gmcculloug