v2v Throttling

[jameswnl]

Moving v2v throttling our of automate

These slides may help understand the changes

Related to ManageIQ/manageiq-content#504 (Corresponding Automate code being replaced/updated)

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1686155

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[agrare]

The target_entity is known at initialization time right? This looks like it could just be an attr_reader that is set in initialize

[jameswnl]

This is caching the query result of target_entity. Shall I rely on rails to take care of caching, and just do a alias_method :migration_task, :target_entity?

[agrare]

Oh no problem with the caching, I was saying in initialize you could do @migration_task = target_entity and make migration_task an attr_reader which is basically what this duplicates the behavior of.

[miq-bot]

Checked commits jameswnl/manageiq@4709864~...0b1a8c5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 7 offenses detected

app/models/infra_conversion_job.rb

• ❗ - Line 26, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 27, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 28, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 29, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 30, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 62, Col 3 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 94, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.

[jameswnl]

@miq-bot add_lable hammer/yes

[miq-bot]

@jameswnl unrecognized command 'add_lable', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

[jameswnl]

@miq-bot add_label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit d1585b3a59c31d58ee0412fa8ef4daa5c1a26df2
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Feb 27 15:46:02 2019 -0500

    Merge pull request #18415 from jameswnl/throttle
    
    v2v Throttling
    
    (cherry picked from commit e3e7c38b24a445f50ded7bf15438fadd0da9294a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1686877