[MiqWorker::worker_settings] Handle number strings #18453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Anything outside of the workers section won't get this fix but hopefully most of the number strings people set are for the workers. |
NickLaMuro
force-pushed
the
handling_integer_strings_in_worker_settings
branch
from
8b440fe
to
7a4c8d0
Compare
Fryguy
reviewed
Feb 13, 2019
|
Overall LGTM...had one minor comment but we could probably merge without it. |
Due to some UI specific issues, settings in the config can be set as "integer strings", or a string that is just a integer (floats are also possible). This doesn't work booting workers as it initializes them with incorrect values. This does some extra checking to avoid that.
NickLaMuro
force-pushed
the
handling_integer_strings_in_worker_settings
branch
from
7a4c8d0
to
eee01fb
Compare
|
Checked commit NickLaMuro@eee01fb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Feb 14, 2019
…_worker_settings [MiqWorker::worker_settings] Handle number strings (cherry picked from commit 2f897c5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1677409
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some UI specific issues, settings in the config can be set as "integer strings", or a string that is just a integer (floats are also possible). This doesn't work booting workers as it initializes them with incorrect values.
This does some extra checking to avoid that.
Links