[HAMMER] Change factories from vm_vmware to vm_openstack. #18466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
changed the title
|
Checked commit https://github.com/djberg96/manageiq/commit/857772b3fc931841f2aaf0a7d080fd46ef213a55 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Feb 19, 2019
|
The remaining Travis failures are caused by other PRs and not related to #18451, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR to #18451, which passed on master but failed on hammer. The fundamental issue is that the
vm_vmwarefactory has a location with brackets and spaces in it, which is throwing off the expectations, though the behavior is correct as far as I can tell.In master the factory was changed to
vm_openstack, so I just altered the specs to use that instead.