Add service_template_ansible_tower factory, inherit naming from parent #18474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
|
Checked commit d-m-u@6cb9b49 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label test |
tinaafitz
approved these changes
Feb 21, 2019
|
Unnecessary factories were removed in favor of https://github.com/ManageIQ/manageiq/blob/cdfb8d6e209d42f3cb1976267b4a501b0aaa4775/spec/support/missing_factory_helper.rb so you can still use |
bdunne
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for #18464 to pass.
We should be inheriting the naming of these from the parent because we validate that they all have names, so I've no idea why it was written to only have the naming set on a couple to start with.
Related to
#18464