Add an inventory_collection for the EMS #18484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some attributes that need to be updated on the EMS record by the parser. For graph refresh this is currently done by directly doing an ems.update_attributes! in the parser which breaks our "parser shouldn't connect to the DB" rule. This adds an inventory collection which allows the parser to set properties to be saved on the ext_management_system record.
|
Checked commit agrare@27131db with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Ladas
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some attributes that need to be updated on the EMS record by
the parser. For graph refresh this is currently done by directly doing
an ems.update_attributes! in the parser which breaks our "parser
shouldn't connect to the DB" rule.
This adds an inventory collection which allows the parser to set
properties to be saved on the ext_management_system record.
Example: ManageIQ/manageiq-providers-vmware#376