Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Service access #18487

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 26, 2019

When fetching services through the api

api/services
  expand=resources
  attributes=picture,
             picture.image_href,
             chargeback_report,
             evm_owner.userid,
             v_total_vms,
             power_state,
             all_service_children,
             tags
  filter[]=ancestry=null

  sort_by=created_at
  sort_options=
  sort_order=desc
  limit=20
  offset=0

reduce calls to database

ms bytes objects query qry ms rows comments
570.4 25,230,444* 334,164 165 50.8 53 orig
537.5 24,482,568* 328,012 145 51.6 53 atomic

* Memory usage does not reflect 4 freed objects.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1656371

When fetching services through the api

api/services
  expand=resources
  attributes=picture,
             picture.image_href,
             chargeback_report,
             evm_owner.userid,
             v_total_vms,
             power_state,
             all_service_children,
             tags
  filter[]=ancestry=null

  sort_by=created_at
  sort_options=
  sort_order=desc
  limit=20
  offset=0

reduce calls to database

|       ms |       bytes | objects |query |  qry ms |     rows |comments
|      ---:|         ---:|     ---:|  ---:|     ---:|      ---:| ---
|    570.4 | 25,230,444* | 334,164 |  165 |    50.8 |       53 |orig
|    537.5 | 24,482,568* | 328,012 |  145 |    51.6 |       53 |atomic

\* Memory usage does not reflect 4 freed objects.
@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2019

Checked commit kbrock@ff8ee93 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@kbrock kbrock changed the title [WIP] Speed up Service access Speed up Service access Mar 22, 2019
@kbrock kbrock removed the wip label Mar 22, 2019
@Fryguy Fryguy merged commit 20b5b2d into ManageIQ:master Mar 25, 2019
@Fryguy Fryguy added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 25, 2019
@Fryguy Fryguy self-assigned this Mar 25, 2019
@Fryguy Fryguy removed the bug label Mar 25, 2019
@kbrock kbrock deleted the service_vms-power_state branch April 2, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants