Only run preprocess_targets_manager_refresh when doing graph refresh and add specs #18513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run preprocess_targets_manager_refresh on an EMS that isn't using graph refresh then we accidentally disable targeted refresh due to the ems.allow_targeted_refresh? check which was a setting that was never added to classic refresh.
|
Checked commits agrare/manageiq@932fb53~...e8ee67a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Mar 4, 2019
agrare
commented
Mar 4, 2019
| if targets.any? { |t| t.kind_of?(ExtManagementSystem) } | ||
| targets_for_log = targets.map { |t| "#{t.class} [#{t.name}] id [#{t.id}] " } | ||
| _log.info("Defaulting to full refresh for EMS: [#{ems.name}], id: [#{ems.id}], from targets: #{targets_for_log}") if targets.length > 1 | ||
| end |
There was a problem hiding this comment.
This logic is handled down here
so this isn't needed anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we run preprocess_targets_manager_refresh on an EMS that isn't using graph refresh then we accidentally disable targeted refresh due to the ems.allow_targeted_refresh? check which was a setting that was never added to classic refresh.
Introduced by refactoring in #18312. This would have been a bug if we had turned off graph refresh for any provider inheriting from that class also, but now it used by everyone.