-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Expose virt-v2v-wrapper error message in options hash #18564
Merged
agrare
merged 1 commit into
ManageIQ:master
from
fabiendupont:v2v_error_reporting_expose_virtv2v_message
Mar 19, 2019
Merged
[V2V] Expose virt-v2v-wrapper error message in options hash #18564
agrare
merged 1 commit into
ManageIQ:master
from
fabiendupont:v2v_error_reporting_expose_virtv2v_message
Mar 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Mar 18, 2019
ghost
changed the title
Expose virt-v2v-wrapper error message in options hash
[V2V] Expose virt-v2v-wrapper error message in options hash
Mar 18, 2019
Checked commit fabiendupont@51f100f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
djberg96
approved these changes
Mar 18, 2019
Looks ok to me. :) |
agrare
approved these changes
Mar 19, 2019
agrare
added a commit
that referenced
this pull request
Mar 19, 2019
…ose_virtv2v_message [V2V] Expose virt-v2v-wrapper error message in options hash
ghost
deleted the
v2v_error_reporting_expose_virtv2v_message
branch
March 19, 2019 12:33
simaishi
pushed a commit
that referenced
this pull request
Apr 4, 2019
…ose_virtv2v_message [V2V] Expose virt-v2v-wrapper error message in options hash (cherry picked from commit a617d3c) https://bugzilla.redhat.com/show_bug.cgi?id=1693747
Hammer backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the disk conversion fails, the error message is really vague: Disk Transformation failed, so the user needs to look into the wrapper and virt-v2v logs to identify the cause. Since recently, virt-v2v-wrapper provides a human-readable error message based on virt-v2v log. An example is below
This PR exposes the message from virt-v2v-wrapper in the task options hash, so that it can be consumed by Automate and the UI.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1595365