Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Expose virt-v2v-wrapper error message in options hash #18564

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2019

When the disk conversion fails, the error message is really vague: Disk Transformation failed, so the user needs to look into the wrapper and virt-v2v logs to identify the cause. Since recently, virt-v2v-wrapper provides a human-readable error message based on virt-v2v log. An example is below

    {
      "started": true,
      "disks": [
        {
          "path": "[datastore13] tg-mini2/tg-mini2_3.vmdk",
          "progress": 100
        },
        {
          "path": "[datastore13] tg-mini2/tg-mini2_4.vmdk",
          "progress": 100
        }
      ],
      "pid": 30375,
      "disk_count": 2,
      "return_code": 0,
      "failed": true,
      "finished": true,
      "last_message": {
        "message": "Failed to create port",
        "type": "error"
      }
    }

This PR exposes the message from virt-v2v-wrapper in the task options hash, so that it can be consumed by Automate and the UI.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1595365

@ghost ghost changed the title Expose virt-v2v-wrapper error message in options hash [V2V] Expose virt-v2v-wrapper error message in options hash Mar 18, 2019
@ghost
Copy link
Author

ghost commented Mar 18, 2019

@miq-bot add_label transformation, enhancement, hammer/yes
@miq-bot add_reviewer @djberg96
@miq-bot add_reviewer @agrare

@miq-bot
Copy link
Member

miq-bot commented Mar 18, 2019

Checked commit fabiendupont@51f100f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@djberg96
Copy link
Contributor

Looks ok to me. :)

@agrare agrare self-assigned this Mar 19, 2019
@agrare agrare merged commit 51f100f into ManageIQ:master Mar 19, 2019
agrare added a commit that referenced this pull request Mar 19, 2019
…ose_virtv2v_message

[V2V] Expose virt-v2v-wrapper error message in options hash
@agrare agrare added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 19, 2019
@ghost ghost deleted the v2v_error_reporting_expose_virtv2v_message branch March 19, 2019 12:33
simaishi pushed a commit that referenced this pull request Apr 4, 2019
…ose_virtv2v_message

[V2V] Expose virt-v2v-wrapper error message in options hash

(cherry picked from commit a617d3c)

https://bugzilla.redhat.com/show_bug.cgi?id=1693747
@simaishi
Copy link
Contributor

simaishi commented Apr 4, 2019

Hammer backport details:

$ git log -1
commit aa22a823bf38b56b4c82fb8b0cac937016af6cb0
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Mar 19 11:39:40 2019 +0100

    Merge pull request #18564 from fdupont-redhat/v2v_error_reporting_expose_virtv2v_message
    
    [V2V] Expose virt-v2v-wrapper error message in options hash
    
    (cherry picked from commit a617d3c7033e3b37e9153466efd75468918a827e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1693747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants