[V2V] Fix ConversionHost active_tasks method to use state == 'migrate' #18570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
reviewed
Mar 19, 2019
app/models/conversion_host.rb
Outdated
| @@ -5,7 +5,7 @@ class ConversionHost < ApplicationRecord | |||
|
|
|||
| belongs_to :resource, :polymorphic => true | |||
| has_many :service_template_transformation_plan_tasks, :dependent => :nullify | |||
| has_many :active_tasks, -> { where(:state => 'active') }, :class_name => ServiceTemplateTransformationPlanTask, :inverse_of => :conversion_host | |||
| has_many :active_tasks, -> { where(:state => 'migrate') }, :class_name => ServiceTemplateTransformationPlanTask, :inverse_of => :conversion_host | |||
There was a problem hiding this comment.
The paranoia in me thinks we should allow either.
|
Checked commits fabiendupont/manageiq@b734a0d~...693c280 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Mar 19, 2019
agrare
added a commit
that referenced
this pull request
Mar 19, 2019
…ate_state [V2V] Fix ConversionHost active_tasks method to use state == 'migrate'
simaishi
pushed a commit
that referenced
this pull request
Mar 19, 2019
…ate_state [V2V] Fix ConversionHost active_tasks method to use state == 'migrate' (cherry picked from commit 7407f63) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686877
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the throttling feature has been moved to the backend, the state for an active task has become
migrate, instead ofactive. This has not been updated in theConversionHost.active_tasksrelationship, which leads to have always zero active tasks reported.This PR fixes that by changing the state lookup to
migrate.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1686877