honor storage_file_collection_time_utc setting #18585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
storage_file_collection_time_utc
setting is not honored, instead the seconds setting is disregarded and its just sets the time to midnight utc.Default Setting:
Current operation of adding the seconds to the current date being disregarded:
Changes to support adding the defined seconds to the beginning of the current day:
This was the simplest change but it might be worth adjusting the default setting to more align with other time settings and define it as
x.seconds
fixes #18586