fix: swap makes vms out of disk space report false positive #18623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiqExpressions convert nil to a floating point number (which is 0) nil <= 20 == true nil.to_f ==> 0 0 <= 20 == true Swap partitions have a nil free_space / free_space_percentage. so free_space_percentage <= 20 shows true for swap So any vm with a swap partition will say it is low on disk space. Fix is to ask if used space is over 80% nil >= 80 == false nil.to_f ==> 0 0 >= 80 == false https://bugzilla.redhat.com/show_bug.cgi?id=1686281
|
Checked commit kbrock@0daf0d2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2019
fix: swap makes vms out of disk space report false positive (cherry picked from commit 629474c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696420
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqExpressions convert nil to a floating point number. In ruby this is a 0.Swap partitions have a nil free_space / free_space_percentage.
so free_space_percentage <= 20 shows true for swap
So any vm with a swap partition will say it is low on disk space.
Fix is to ask if used space is over 80%
Now, there are no false positives for running out of disk space.
https://bugzilla.redhat.com/show_bug.cgi?id=1686281