Remove deprecated Optimize Planning - shortcuts and user roles #18624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregP
force-pushed
the
remove_deprecated_optimize_planning_shortcut
branch
3 times, most recently
from
584cc6a
to
c37d3a5
Compare
GregP
changed the title
GregP
force-pushed
the
remove_deprecated_optimize_planning_shortcut
branch
3 times, most recently
from
c39d69b
to
e550d34
Compare
GregP
force-pushed
the
remove_deprecated_optimize_planning_shortcut
branch
from
e550d34
to
d1299f1
Compare
|
Checked commits GregP/manageiq@49fbb62~...d1299f1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
GregP
changed the title
|
@h-kataria Ready for review. |
h-kataria
reviewed
May 22, 2019
| @@ -110,127 +110,6 @@ def storages_for_compute_target(target) | |||
| end | |||
| end | |||
|
|
|||
| # This method answers C&U Planning question 2 | |||
There was a problem hiding this comment.
@Fryguy @gtanzillo can you guys look at deleted methods here, is it safe to delete these methods.
There was a problem hiding this comment.
@h-kataria I checked and is should be safe to remove these 2 methods 👍
|
looks good, verified in UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and removes Optimize Planning code and settings. This is a multi-part PR/commit. Complements this PR and should be merged along with it:
ManageIQ/manageiq-ui-classic#5430
https://bugzilla.redhat.com/show_bug.cgi?id=1672934
Screen shot of main menu selections prior to code fix:
