Check that reconfigure is supported before we try it #18636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@miq-bot add_label hammer/yes |
d-m-u
changed the title
d-m-u
force-pushed
the
catch_attribute_error_better
branch
2 times, most recently
from
df0bfb1
to
682bc05
Compare
jrafanie
reviewed
Apr 8, 2019
d-m-u
force-pushed
the
catch_attribute_error_better
branch
from
682bc05
to
441ad79
Compare
|
Checked commit d-m-u@441ad79 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
changed the title
|
@miq-bot remove_label wip |
|
can i get anyone to look at this please? |
|
This fix works perfectly and keeps the API happy. Thanks @d-m-u for taking care of this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would expect
GET /api/services/:id?attributes=reconfigure_dialogto check that the reconfigure is valid before running it rather than getting aninternal_server_error from undefined method `dialog_tabs' for nil:NilClassbecause the reconfigure was called on a dialog without the endpoint set up (or without fields set to be reconfigureable). We have the supports_feature mixin on the reconfigure so we should use it." services shouldn't behave different than anything else with virtual associations", the man says.
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1663972