Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAMMER] [V2V] Refactor ConversionHost to use AuthenticationMixin #18673

Merged
merged 2 commits into from
Apr 25, 2019
Merged

[HAMMER] [V2V] Refactor ConversionHost to use AuthenticationMixin #18673

merged 2 commits into from
Apr 25, 2019

Conversation

djberg96
Copy link
Contributor

This is essentially a clone of #18309. The primary difference is that this PR does not modify the AuthenticationMixin module. Doing so caused failures in at least one provider.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1702051

Replaces #18634 which I got goofed up on a botched rebase.

@Fryguy
Copy link
Member

Fryguy commented Apr 23, 2019

@agrare Can you take a look at this?

@djberg96
Copy link
Contributor Author

djberg96 commented Apr 23, 2019

@agrare Hang on, need to fix something, accidentally mixed in code from a different PR.
Ok, updated.

@miq-bot
Copy link
Member

miq-bot commented Apr 23, 2019

Checked commits https://github.com/djberg96/manageiq/compare/11ae1363e71c297d42990fdecb6c1a14a95f7313~...88b1d8655eac610dec0f849be88dda04c83f1273 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 3 offenses detected

app/models/conversion_host.rb

@agrare
Copy link
Member

agrare commented Apr 23, 2019

@djberg96 so without the change to the AuthenticationMixin what else had to change on this backport? This looks identical as far as I can see with a quick once over

@djberg96
Copy link
Contributor Author

@agrare The difference was the behavior change in available_authentications and authentication_key_pairs.

@djberg96
Copy link
Contributor Author

@agrare Oh, misread that last comment. Didn't think anything else needed to change since it's just openstack and rhev for now.

@simaishi simaishi merged commit dd5b6c5 into ManageIQ:hammer Apr 25, 2019
@simaishi simaishi added this to the Sprint 110 Ending Apr 29, 2019 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants