Add source to retire request to parse in parse_prov_category in engine #18738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @tinaafitz |
|
@d-m-u Cannot apply the following label because they are not recognized: yuck |
d-m-u
force-pushed
the
add_source_to_vm_retire_request
branch
2 times, most recently
from
42f9e7c
to
1f4e03b
Compare
d-m-u
force-pushed
the
add_source_to_vm_retire_request
branch
from
1f4e03b
to
5f16c19
Compare
d-m-u
force-pushed
the
add_source_to_vm_retire_request
branch
from
5f16c19
to
f579458
Compare
|
Checked commit d-m-u@f579458 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
May 7, 2019
simaishi
pushed a commit
that referenced
this pull request
May 7, 2019
Add source to retire request to parse in parse_prov_category in engine (cherry picked from commit a10933d) https://bugzilla.redhat.com/show_bug.cgi?id=1707456
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hadn't kept the source_id and source_type in the vm_retire_request previously because Automate hadn't been wired to do the auto-approval correctly. With the recent removal of auto-approval from the retirement mixin make_request, we need this change and also an incoming Automate change to have the state machine handle approval correctly.
Part of fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1706208
related to
ManageIQ/manageiq-content#532