Add option to schedule automation requests via workflow #18741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
|
@d-m-u Cannot apply the following label because they are not recognized: enhancement |
|
@miq-bot add_label enhancement |
|
@d-m-u unrecognized command 'unassign', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone |
d-m-u
force-pushed
the
adding_scheduling_option_to_automation_request
branch
6 times, most recently
from
aa1b124
to
683431e
Compare
|
@miq-bot remove_label wip |
d-m-u
changed the title
d-m-u
force-pushed
the
adding_scheduling_option_to_automation_request
branch
2 times, most recently
from
6f879de
to
75387cc
Compare
|
anyone want to review this? |
jrafanie
reviewed
May 13, 2019
jrafanie
requested changes
May 13, 2019
d-m-u
force-pushed
the
adding_scheduling_option_to_automation_request
branch
from
75387cc
to
e086131
Compare
|
Checked commit d-m-u@e086131 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutomationRequests should have the same scheduling option as we have with provisioning requests. This is the counterpart to ManageIQ/manageiq-api#583. The option gets used https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_request_task.rb#L174 when the task gets queued.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1486765
related to
ManageIQ/manageiq-api#583