Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2V] Restore auth_user in conversion host context data #18819

Merged
merged 1 commit into from
May 29, 2019
Merged

[V2V] Restore auth_user in conversion host context data #18819

merged 1 commit into from
May 29, 2019

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 29, 2019 •
edited
Loading

The code for ConversionHost::Configurations splits out the auth_user from the incoming params, so it needs to be restored as a param in the context data so that a retry will pick it up again.

https://bugzilla.redhat.com/show_bug.cgi?id=1713394

@djberg96
Copy link
Contributor Author

@miq-bot add_labels transformation, hammer/yes

@djberg96
Copy link
Contributor Author

@miq-bot add_label bug

@djberg96
Copy link
Contributor Author

@miq-bot add_reviewer @agrare

@miq-bot miq-bot requested a review from agrare May 29, 2019 14:58
@miq-bot
Copy link
Member

miq-bot commented May 29, 2019

Checked commit https://github.com/djberg96/manageiq/commit/88a4f6169080d4c5852b194bf0b90904c9324292 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare self-assigned this May 29, 2019
@agrare agrare merged commit 184bb9d into ManageIQ:master May 29, 2019
@agrare agrare added this to the Sprint 113 Ending Jun 10, 2019 milestone May 29, 2019
simaishi pushed a commit that referenced this pull request Jun 10, 2019
@agrare @simaishi
Merge pull request #18819 from djberg96/conversion_host_auth_user
aa86709 
[V2V] Restore auth_user in conversion host context data

(cherry picked from commit 184bb9d)

https://bugzilla.redhat.com/show_bug.cgi?id=1717023
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit aa86709453e65c50badf90ece07222cd309c08c5
Author: Adam Grare <agrare@redhat.com>
Date:   Wed May 29 11:28:14 2019 -0400

    Merge pull request #18819 from djberg96/conversion_host_auth_user
    
    [V2V] Restore auth_user in conversion host context data
    
    (cherry picked from commit 184bb9d3864d84b91903bc0003a9d77362f5863c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1717023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug hammer/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djberg96 @miq-bot @simaishi @agrare